Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build & update build scripts #185

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

palainp
Copy link
Member

@palainp palainp commented Nov 8, 2023

This PR wants to address #183 and #184:

  • With Qubes 4.2 SELinux policies are enforced and now we need to run an additional command to be allowed to store docker images in the user homedir
  • A recent update in opam-overlay changed the result hashsum, therefore I updated the build scripts (change from notset.fr to official debian repositories, update to mirage 4.4.0, ...)

@hannesm
Copy link
Member

hannesm commented Nov 8, 2023

thanks, looks good to me :)

@palainp
Copy link
Member Author

palainp commented Nov 8, 2023

Thank you @hannesm!
I just try to pin the opam-overlay directory to fix the last reproducibility issue before merging.

@hannesm
Copy link
Member

hannesm commented Nov 8, 2023

FWIW, we can from a release link to the build-info from https://builds.robur.coop/hash?sha256=<SHA256-of-the-unikernel-image>. And hopefully in the future document how you can replay / rebuild it ;) (there's orb rebuild - but we do not test this periodically -- it also lacks the information that you should run it in that specific docker container, and the apt/sources.list is not stored)

@palainp
Copy link
Member Author

palainp commented Nov 8, 2023

So pinning opam-overlay to an earlier commit permits me to get the previous hash. I think the situation is better now.

@palainp
Copy link
Member Author

palainp commented Nov 8, 2023

The last commit is to inform the user about the temporary disk usage with docker (thanks to @ben-grande for pointing out that in #186).

@hannesm
Copy link
Member

hannesm commented Nov 8, 2023

I do approve these changes. thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants